Stas Bekman wrote:
Geoffrey Young wrote:
what about just api_version()? I think that sets it apart enough from perlish ideas about require() and provides a means to explain the exactness of the required match.
+1 for the exactness, but it's still ambiguous of what api_ it's talking
about. apr API, mod_perl API, perl API, apache API?
ok, apache_api_version() then? I'd hate to see it any longer than that.
+1
Patch attached.
------------------------------------------------------------------------
Index: Changes
===================================================================
RCS file: /home/cvs/modperl-2.0/Changes,v
retrieving revision 1.485
diff -u -I$Id -r1.485 Changes
--- Changes 16 Sep 2004 16:36:28 -0000 1.485
+++ Changes 16 Sep 2004 20:10:49 -0000
@@ -12,6 +12,9 @@
=item 1.99_17-dev
+Apache::Module $mod->version() renamed $mod->apache_api_version()
+for clarity [Gozer]
+
Apache::Log changes: [Stas]
- moved to compat: Apache::warn, Apache->warn, Apache::Server->warn,
Apache::Server::warn
Index: t/response/TestAPI/module.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/response/TestAPI/module.pm,v
retrieving revision 1.22
diff -u -I$Id -r1.22 module.pm
--- t/response/TestAPI/module.pm 13 Sep 2004 22:36:18 -0000 1.22
+++ t/response/TestAPI/module.pm 16 Sep 2004 20:10:49 -0000
@@ -84,7 +84,7 @@
my $name = $modp->name;
ok $name;
t_debug("Testing module: " . $modp->name);
- ok $modp->version == $mmn_major;
+ ok $modp->apache_api_version == $mmn_major;
ok $modp->minor_version <= $mmn_minor;
ok $modp->module_index >= 0;
my $cmds = $modp->cmds;
while you are at it, change those to use t_cmp to make those tests more debuggable.
Otherwise looks good
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
