Re: dropping $finfo->pool?

[Philippe M. Chiasson]

Joe Schaefer wrote:

Stas Bekman <[EMAIL PROTECTED]> writes:

[...]

I don't understand what this pool is for. the C docs for
the record entry are totally unclear.

Since apr_file_t is an opaque structure in C, the
only way to extract any information about it is by calling apr_file_info_get() and inspecting the corresponding apr_finfo_t struct. Otherwise the
pool slot serves no useful purpose:

% grep -r "finfo->pool" .
./file_io/netware/filestat.c: finfo->pool = thefile->pool;
./file_io/netware/filestat.c: finfo->pool = pool;
./file_io/os2/dir.c: finfo->pool = thedir->pool;
./file_io/unix/dir.c: finfo->pool = thedir->pool;
./file_io/unix/filestat.c: finfo->pool = thefile->pool;
./file_io/unix/filestat.c: finfo->pool = pool;
./file_io/win32/dir.c: finfo->pool = thedir->pool;
./file_io/win32/filestat.c: apr_pool_cleanup_register(finfo->pool, pdesc, free_localheap,
./file_io/win32/filestat.c: finfo->pool = thefile->pool;
./file_io/win32/filestat.c: finfo->pool = pool;
./file_io/win32/filestat.c: finfo->pool = pool;

Feels to me like there is not much motivation for opening up finfo->pool then

signature.asc
Description: OpenPGP digital signature