Stas Bekman wrote:

Philippe M. Chiasson wrote:

When looking for apr-config/apu-config in httpd's source tree, look
both in srclib/apr and srclib/apr-util


+1 on the concept, but it'd be nice to rewrite this section. That $_ is not the most beautiful part of it. I think using

 for my $base (grep defined $_, $self->dir)
    ...
    push @tries

or something like that will make the code more readable

Yes, you're right. The following patch was checked-in instead. Much leaner

        if ($self->httpd_is_source_tree) {
-            push @tries, grep { -d $_ }
-                map catdir($_, "srclib", "apr"),
-                grep defined $_, $self->dir;
+            for my $base (grep defined $_, $self->dir) {
+                push @tries, grep -d $_,
+                    map catdir($base, "srclib", $_), qw(apr apr-util);
+            }


Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to