On Tue, Sep 28, 2004 at 12:32:36PM -0400, Joe Schaefer wrote:
Stas Bekman <[EMAIL PROTECTED]> writes:
[...]
Any ideas about how to fix the segfaults at startup time too?
I'll try to reproduce it now.
I'm able to get these segfults now, but not reliably.
BTW it was useful to have the pools tagged when looking through the core dump, I noticed that mod_perl doesn't do this for all pools.
Index: mod_perl.c
===================================================================
RCS file: /home/cvspublic/modperl-2.0/src/modules/perl/mod_perl.c,v
retrieving revision 1.222
diff -u -r1.222 mod_perl.c
--- mod_perl.c 21 Sep 2004 21:35:30 -0000 1.222
+++ mod_perl.c 28 Sep 2004 21:35:27 -0000
@@ -539,6 +539,7 @@
MP_init_status = 1; /* now starting */
apr_pool_create(&server_pool, pconf);
+ apr_pool_tag(server_pool, "mod_perl server pool");
modperl_sys_init();
apr_pool_cleanup_register(pconf, NULL,
that's fine
Index: modperl_filter.c
===================================================================
RCS file: /home/cvspublic/modperl-2.0/src/modules/perl/modperl_filter.c,v
retrieving revision 1.98
diff -u -r1.98 modperl_filter.c
--- modperl_filter.c 9 Sep 2004 15:17:20 -0000 1.98
+++ modperl_filter.c 28 Sep 2004 21:35:28 -0000
@@ -318,6 +318,8 @@
}
filter = (modperl_filter_t *)apr_pcalloc(temp_pool, sizeof(*filter));
+ apr_pool_tag(temp_pool, "mod_perl temp filter");
+
but this one happens at run time, what's the overhead of the pool tagging operation? should we do that only for the maintainer version?
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
