Geoffrey Young wrote:

[EMAIL PROTECTED] wrote:

stas        2004/09/28 15:38:46

 Modified:    t/filter both_str_req_proxy.t
 Log:
 need to use need() if there is more than one skip condition


 -plan tests => 1, (need_module('proxy') && need_access);
 +plan tests => 1, need need_module('proxy'), need_access;


why is that?  I use multiple need_* calls all the time and haven't seen any
issues.

There are no implications on the test. There are implications for users.

  need need_module('proxy'), need_access, ...;

always runs all the requirement checks and reports all the missing requirements. In the case of:

  need_module('proxy') && need_access

if the first requirement fails, the second is not run, and the missing requirement is not reported. So let's say a user wants to satisy all the requirements and run the test suite again. If we report all the requirements right away, he will need to let's say rebuild Apache once, if we report only one requirement at a time, he will have to rebuild it as many times as there are && sides...


-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to