Stas Bekman wrote:
Stas Bekman wrote:
Philippe M. Chiasson wrote:
Stas Bekman wrote:
I've gleaned out almost all the issues with mp2 and 5.6, all were just test tweaks. The only remaining issue is failing: t/perl/api.t, but it doesn't fail on its own, so I'm running the SMOKE for it now. Hopefully will know the answer by tomorrow.
Please let me know if you see any other problems besides this test when running under perl 5.6. Thanks.
Here is the result of a test run this morning Perl 5.6.1 httpd 2.0.51/prefork
-------------8<---------- Start Bug Report ------------8<---------- 1. Problem Description:
Virtually every single test fails, and the only error showing up in the error_log is :
Undefined subroutine &Apache::RequestRec::AUTOLOAD called.\n [...]
Many, many times. (Obviously, this is probably only one problem ;-)
All due to this temp workaround that is no longer in cvs:
PerlPostReadRequestHandler 'sub { use Apache::Const qw(DECLINED); DECLINED }'
You shouldn't have any problems with the current cvs, either with 5.6.1 w/ or w/o ithreads.
I'll try to work on a test for this problem.
And indeed there is bug for non-ithreads perl builds, where it was caching the compiled anonsub, but w/o incrementing the refcount. The fix is as follows, trying to write a good test for it before I commit that.
Nice catch there stas! With your patch applied:
All tests successful, 16 tests skipped. Files=218, Tests=3295, 165 wallclock secs (103.54 cusr + 15.36 csys = 118.90 CPU)
with non threaded 5.6.1 ;-)
Index: src/modules/perl/modperl_callback.c =================================================================== RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_callback.c,v retrieving revision 1.78 diff -u -r1.78 modperl_callback.c --- src/modules/perl/modperl_callback.c 28 Sep 2004 18:14:30 -0000 1.78 +++ src/modules/perl/modperl_callback.c 29 Sep 2004 03:49:34 -0000 @@ -79,6 +79,7 @@ if (!handler->cv) { SV *sv = eval_pv(handler->name, TRUE); handler->cv = (CV*)SvRV(sv); /* cache */ + SvREFCNT_inc(handler->cv); } cv = handler->cv; #endif
-- -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
