Randy Kobes wrote:
[...]
Is it possible that the right place to fix that is in modperl_common_util.h:

#ifdef WIN32
#   define MP_FUNC_T(name) (_stdcall *name)

So perhaps, in analogy, we could have a

  #ifdef WIN32
  #   define MP_DECLARE(name)         *name __stdcall
  #   define MP_DECLARE_NONSTD(name)  *name
  /* XXX: not all functions get inlined
  * so its unclear what to and not to include in the .def files
  */
 #   undef MP_INLINE
 #   define MP_INLINE
 #else
 #   define MP_DECLARE(name)         *name
 #   define MP_DECLARE_NONSTD        *name
 #endif

and then use MP_DECLARE/MP_DECLARE_NONSTD?

+1, but I'd rather keep our more intuitive name: will MP_FUNC_T and MP_FUNC_NONSTD_T do? If so go ahead and commit it. But don't forget the parentheses: (*name) and the arguments to the macro :)




--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to