Stas Bekman <[EMAIL PROTECTED]> writes:
setaside API needs to be changed as it strays from the rest of the
API. Since all it can return is errors which are useless to trap it
shouldn't return anything. It should run MP_RUN_CROAK like other
methods do. It's still possible to trap those with APR::Error, but who
will.
You should allow users to check for APR_ENOTIMPL, because
But your implementation of modperl_bucket_sv_setaside doesn't ever return it. I'm not following you, Joe.
they might be able to handle that case the same way ap_save_brigade does. So I agree that it should throw an exception in void context, but would prefer if it didn't do that in scalar/list context.
I don't think it makes sense in the particular case of mod_perl. The only users of modperl buckets are modperl users, and setaside is now implemented. So why would users want to check any success codes explicitly?
Joe, please let me know if you want to do that, or I can handle that.
Please fix it for me Stas- thanks!
Sure, once we figure out what exactly needs to be done.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
