Philippe M. Chiasson wrote:
Stas Bekman wrote:
Philippe M. Chiasson wrote: [...]
it's probably always a good idea to discuss first before spending time on things :)
So, what do we do about it? Yank it out, document better alternatives, like
CGI::Util::unescape() and possibly implement in Apache/compat.pm as :
unescape_url() =~ s/\+/ /g;
Implement it in Apache/compat.pm *and* document to use CGI::Util::unescape() in mp2?
Here it is:
+1 (plus doc of course :)
There is one more things that needs to be updated, it's $methods_compat in MethodLookup.pm (which is autogenerated from lib/ModPerl/WrapXS.pm), this and the escape_html method should be there (did we forget any other recently added to compat.pm methods?)
escape_html is in there. As for other compat methods, I'll look into it, must be missing some, since I was completely unaware of the need to update that list.
As for the patch itself, it's in, with doc and all.
-- -------------------------------------------------------------------------------- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
signature.asc
Description: OpenPGP digital signature
