Stas Bekman wrote:
Max Maischein via RT wrote:
the Apache::Test Makefile.PL enters an infinite loop when it is
running without a connected terminal and can't find the path to
httpd. This is very bad for CPAN testers who maybe don't have a
httpd binary somewhere to be found, and where the testing runs
unattended. Please use the prompt() function in ExtUtils::MakeMaker
and don't enter a loop if the default is accepted, or detect that
Makefile.PL is run in unattended mode and don't enter the loop at all.
[...]
Index: lib/Apache/TestRun.pm
===================================================================
--- lib/Apache/TestRun.pm (revision 106304)
+++ lib/Apache/TestRun.pm (working copy)
@@ -1284,6 +1284,9 @@
sub skip_test_suite {
my $no_doubt = shift;
+ # we can't prompt when there is no STDIN;
+ $no_doubt = 1 unless -t STDIN;
+
print qq[
Running the test suite is important to make sure that the module that
Index: lib/Apache/TestConfig.pm
===================================================================
--- lib/Apache/TestConfig.pm (revision 106304)
+++ lib/Apache/TestConfig.pm (working copy)
@@ -2090,6 +2090,11 @@
my $self = shift;
my $conf_opts = shift;
+ unless (-t STDIN) {
+ error "STDIN is closed, can't run interactive config";
+ Apache::TestRun::skip_test_suite();
+ }
+
my $vars = $self->{vars};
print qq[
In any case, it's in. Let me know if you still have problems with it.
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
