[EMAIL PROTECTED] wrote:
else { + unless ($build->{MP_USE_STATIC}) {
This one check has been standardized as $build->should_build_apache();
Right, but since:
sub should_build_apache {
my ($self) = @_;
return $self->{MP_USE_STATIC} ? 1 : 0;
}if you look at the loop:
if ($build->{MP_APXS}) {
...
}
elsif ($build->{MP_AP_PREFIX}) {
...
}
else {
unless ($build->{MP_USE_STATIC}) {
...
}
}it's easier to parse, than:
if ($build->{MP_APXS}) {
...
}
elsif ($build->{MP_AP_PREFIX}) {
...
}
else {
unless ($build->should_build_apache) {
...
}
}no?
Remind me please why did we add this wrapper? I think it used to be something more complex but now it's really just $self->{MP_USE_STATIC} ? 1 : 0;
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
