Hi Perrin,

I've massaged a bit more the ported SizeLimit.pm, but I've a question regarding:

sub setmax {
    $MAX_PROCESS_SIZE = shift;
    my $r = Apache->request();

and similar:

sub setmin {
sub setmax_unshared {

Since Apache->request() is not longer available by default, should we change the API to pass $r as the first argument? or may be the second?

setmax($MAX_PROCESS_SIZE, $r);
setmax($MAX_PROCESS_SIZE); # here will try to use Apache->request()

I suppose this is a better approach, since it won't break the existing code, making $r optional.

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to