Stas Bekman <[EMAIL PROTECTED]> writes:

[...]

> Hmm, the apr part does look wrong:
>
> APU_DECLARE(apr_status_t) apr_brigade_cleanup(void *data)
> {
>      apr_bucket_brigade *b = data;
>      apr_bucket *e;
>
> shouldn't it be:
>
>      apr_bucket_brigade *b = (apr_bucket_brigade *)data;

In C, this cast makes no difference at all; and lots
of C programmers would advise against it.  The likely
reason they use a (void *) argument in apr_brigade_cleanup
instead of an (apr_bucket_brigade *) is because that
function is also registered as a pool cleanup.  I'm 
actually more suspicious of the APU_DECLARE vs 
APU_DECLARE_NONSTD part, because its possible (haven't
checked tho) that Win32's calling coventions are different
for the pool cleanup invocation verses a direct dll 
invocation.

See if you can get wrowe's attention; he'll definitely
know if I'm barking up the wrong tree or not.

-- 
Joe Schaefer


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to