Le 5 janv. 05, � 15:56, Stas Bekman a �crit :
Eric Cholet wrote:
Hi,
Fresh svn checkout of mp2 / apache 2.0 on MacOSX 10.3.
'make test' fails to start the server. t/logs/error_log reveals that Apache::SizeLimit
wants BSD::Resource which wasn't installed on my system.
} elsif (BSD_LIKE) {
# will getrusage work on all BSDs? I should hope so.
if ( eval { require BSD::Resource } ) {
$HOW_BIG_IS_IT = \&bsd_size_check;
} else {
die "you must install BSD::Resource for Apache::SizeLimit " .
"to work on your platform.";
}
Perhaps it would be nicer if this could be detected earlier, unfortunately I'm
still way too clueless to provide a patch.
Ay, for some reason I thought that this was tested for. Pleaes try this patch:
Index: t/conf/post_config_startup.pl =================================================================== --- t/conf/post_config_startup.pl (revision 124181) +++ t/conf/post_config_startup.pl (working copy) @@ -69,7 +69,8 @@ eval { require Apache::SizeLimit }; if ($@) { # unsupported platform - die $@ unless $@ =~ /Apache::SizeLimit not implemented on/; + die $@ unless $@ =~ /Apache::SizeLimit not implemented on/ + or $@ =~ /you must install BSD::Resource/; } }
With this patch the server starts and "make test" runs
Thanks committed.
t/modules/apache_resource...............skipped
all skipped: cannot find module 'BSD::Resource'
ah, right, now I understand why I thought we were already testing for it.
Is the above related to Apache::SizeLimit? In any case it'd be nicer if this could be detected earlier, at perl Makefile.PL or compile time.
No, it's an Apache::Resource test
What do you mean detected? Like offer you a list of optional modules? We have discussed that, but didn't arrive to any firm plan on how the best to do it. How do you propose we deal with that?
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
