Cory Omand wrote: [...]
That's better, Cory, but why introducing new variables? you still kept the old ones, but they aren't used anymore, are they? (e.g. AP_LIBEXECDIR) Looks like a lot of extra noise.
May be keep the old makefile vars unchanged but merge the new prefix transparently into those vars if the prefix exists? or at least drop the not-used vars?
My initial thought was that this should behave like DESTDIR for other packages -- it is only set on installation. Therefore, when you are using AP_LIBEXECDIR, you know it is pointing to where things will be when installed, but AP_LIBEXECDESTDIR is not referenced anywhere in the compilation portions of the makefile. As I have another look through the makefile, however, it appears that the only purpose of the MODPERL_AP_* variables is for installation, so maybe moving to use the existing variable names is fine...
Another patch is attached --
Looks perfect to me, Cory
(it will need a few tiny style tweaks, but don't worry about that).
+1
once others vote on this it can go in.
-- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
