[EMAIL PROTECTED] wrote:
+make sure not to use apr_os_thread_current in debug mode when libapr +wasn't built with threads support [Stas]
+
Apache2::RequestRec->new now sets $r->request_time [Stas]
Modified: perl/modperl/trunk/src/modules/perl/modperl_util.h
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/src/modules/perl/modperl_util.h?view=diff&r1=160300&r2=160301
==============================================================================
--- perl/modperl/trunk/src/modules/perl/modperl_util.h (original)
+++ perl/modperl/trunk/src/modules/perl/modperl_util.h Wed Apr 6 08:05:52 2005
@@ -102,7 +102,11 @@
void modperl_package_unload(pTHX_ const char *package);
#if defined(MP_TRACE) && defined(APR_HAS_THREADS)
#define MP_TRACEf_TID "/tid 0x%lx"
+#if APR_HAS_THREADS
#define MP_TRACEv_TID (unsigned long)apr_os_thread_current()
+#else
+#define MP_TRACEv_TID 0
+#endif
#define MP_TRACEv_TID_ MP_TRACEv_TID,
#define MP_TRACEv__TID ,MP_TRACEv_TID
#else
Stas, appologies... After retesting this, I came to the following: --enable-maintainer-mode _DOES_ imply --enable-threads in APR _BUT_ only if APR is compiled and installed as part of HTTP2.
If you install APR outside of HTTPD2 as a "system library" (I don't think we support this yet as APR isn't quite ready?) then you must also compile APR with --enable-maintainer-mode.
This broke the MP2 requirement of requiring httpd2 to be built with --enable-maintainer-mode as stated on the webpage docs as it assumes
HTTPD2.
Not really, there is no such requirement. I think the issue is different, please see below.
Also, this function was already inside > #if defined(MP_TRACE) && defined(APR_HAS_THREADS)
I did this test against r160300
Oops, that's correct. I've reverted that.
so what you are saying is that httpd has APR_HAS_THREADS but if you get to load a different libapr which doesn't have threads enabled we are screwed. Right?
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
