I am not so surprised ;-) I've seen patches take many more iterations
than this one before going thru. It's one way to keep the codebase
clean and concise (and hopefully bug-free).
Before I rip more of my hair out, I believe this whole thread is going
to be moot. *sigh*.
Explanation:
svn co ...
[no local changes]
make distclean
[just incase]
perl Makefile.PL ...
make
[snipped]
cc
-I/usr/home/pgollucci.local/dev/repos/asf/perl/modperl/trunk/src/modules/perl
-I/usr/home/pgollucci.local/dev/repos/asf/perl/modperl/trunk/xs
-I/usr/home/pgollucci/dev/apps/5.9.3-ithreads_2.3.0_worker/httpd/include
-I/usr/home/pgollucci/dev/apps/5.9.3-ithreads_2.3.0_worker/httpd/include
-I/usr/home/pgollucci.local/dev/repos/asf/httpd/httpd/trunk/srclib/apr-util/../apr-iconv/include
-I/usr/local/include
-I/usr/home/pgollucci/dev/apps/5.9.3-ithreads_2.3.0_worker/httpd/include
-pipe -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -DDEBUGGING
-fno-strict-aliasing *-Wdeclaration-after-statement*
-I/usr/local/include
-I/usr/home/pgollucci/dev/apps/5.9.3-ithreads_2.3.0_worker/perl/lib/CORE
-DMOD_PERL -Wall -Wmissing-prototypes -Wstrict-prototypes
-Wmissing-declarations -Werror -DAP_DEBUG
-DAP_HAVE_DESIGNATED_INITIALIZER -DMP_COMPAT_1X -DMP_DEBUG -DMP_TRACE
-DAP_DEBUG -ggdb3 -O0 -DPIC -fPIC -c mod_perl.c && mv mod_perl.o
mod_perl.lo
You'll notice that its already there. The reason being is that
we grap PERL's ccflags enmass:
lib/Apache2/Build.pm:
sub perl_ccopts {
my $self = shift;
my $cflags = $self->strip_lfs(" $Config{ccflags} ");
From Perl's ./Configure
echo "Checking if your compiler accepts -Wdeclaration-after-statement" 2>&1
echo 'int main(void) { return 0; }' > gcctest.c
if $cc -Wdeclaration-after-statement -o gcctest gcctest.c; then
echo "Yes, it does." 2>&1
case "$ccflags" in
*-Wdeclaration-after-statement*)
echo "Leaving current flags $ccflags alone." 2>&1
;;
*) dflt="$dflt -Wdeclaration-after-statement" ;;
esac
else
echo "Nope, it doesn't, but that's ok." 2>&1
fi
;;
So if we are using GCC and its supported, we get it.
I say the todo is done.
:)
That'll teach me to jump into things :)
P.S.
Appologies for the BCC to the list and others last time, picked the
wrong header type somehow.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
