Hi all,
according to Stas and the style guide,
we write
my(
instead of
my (
I'm in New Hampshire in the woods until Wednesday.
See attached:
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci ([EMAIL PROTECTED]) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com
Index: Makefile.PL
===================================================================
--- Makefile.PL (revision 240189)
+++ Makefile.PL (working copy)
@@ -203,7 +203,7 @@
# we must create a dummy aprext.lib to pass the -e test.
my $lib1 = catfile qw(src modules perl),
$build->{MP_LIBNAME} . $Config{lib_ext};
- my ($apr_blib, $full_libname) = $build->mp_apr_blib();
+ my($apr_blib, $full_libname) = $build->mp_apr_blib();
my $lib2 = catfile $apr_blib, $full_libname;
unless (-d $apr_blib) {
File::Path::mkpath($apr_blib) or die "mkdir $apr_blib failed: $!";
@@ -632,7 +632,7 @@
# must not import File::Spec functions inside MY, it breaks
# 5.6.x builds
- my ($apr_blib, $full_libname) = $build->mp_apr_blib();
+ my($apr_blib, $full_libname) = $build->mp_apr_blib();
my $from = File::Spec->catfile($apr_blib, $full_libname);
(my $ap_lib = $build->ap_includedir()) =~ s{include$}{lib};
my $to = File::Spec->catfile($ap_lib, $full_libname);
Index: t/hooks/TestHooks/stacked_handlers2.pm
===================================================================
--- t/hooks/TestHooks/stacked_handlers2.pm (revision 240189)
+++ t/hooks/TestHooks/stacked_handlers2.pm (working copy)
@@ -49,7 +49,7 @@
my $obj = shift;
- my ($r, $callback);
+ my($r, $callback);
if ($obj->isa('Apache2::Filter')) {
$r = $obj->r;
Index: t/filter/TestFilter/both_str_req_mix.pm
===================================================================
--- t/filter/TestFilter/both_str_req_mix.pm (revision 240189)
+++ t/filter/TestFilter/both_str_req_mix.pm (working copy)
@@ -95,7 +95,7 @@
sub out_adjust_after_ssi { adjust("REMOVE", @_)}
sub adjust {
- my ($string, $filter) = @_;
+ my($string, $filter) = @_;
my $sig = "adjust($string):";
while ($filter->read(my $buffer, 1024)){
Index: t/filter/TestFilter/in_bbs_underrun.pm
===================================================================
--- t/filter/TestFilter/in_bbs_underrun.pm (revision 240189)
+++ t/filter/TestFilter/in_bbs_underrun.pm (working copy)
@@ -116,7 +116,7 @@
}
sub flatten_bb {
- my ($bb) = shift;
+ my($bb) = shift;
my $seen_eos = 0;
Index: t/filter/TestFilter/in_bbs_consume.pm
===================================================================
--- t/filter/TestFilter/in_bbs_consume.pm (revision 240189)
+++ t/filter/TestFilter/in_bbs_consume.pm (working copy)
@@ -66,7 +66,7 @@
# if $scan_only is true, don't read the data, just look for eos
sub bb_data_n_eos {
- my ($bb, $scan_only) = @_;
+ my($bb, $scan_only) = @_;
if ($scan_only) {
for (my $b = $bb->first; $b; $b = $bb->next($b)) {
Index: t/filter/TestFilter/in_init_basic.pm
===================================================================
--- t/filter/TestFilter/in_init_basic.pm (revision 240189)
+++ t/filter/TestFilter/in_init_basic.pm (working copy)
@@ -35,7 +35,7 @@
sub transparent : FilterRequestHandler
FilterHasInitHandler(\&transparent_init)
{
- my ($filter, $bb, $mode, $block, $readbytes) = @_;
+ my($filter, $bb, $mode, $block, $readbytes) = @_;
my $ctx = $filter->ctx;
$ctx->{run}++;
Index: t/filter/TestFilter/out_init_basic.pm
===================================================================
--- t/filter/TestFilter/out_init_basic.pm (revision 240189)
+++ t/filter/TestFilter/out_init_basic.pm (working copy)
@@ -41,7 +41,7 @@
sub transparent : FilterRequestHandler
FilterHasInitHandler(get_pre_handler())
{
- my ($filter, $bb) = @_;
+ my($filter, $bb) = @_;
#warn "**** filter was invoked\n";
Index: t/filter/TestFilter/out_str_buffer.pm
===================================================================
--- t/filter/TestFilter/out_str_buffer.pm (revision 240189)
+++ t/filter/TestFilter/out_str_buffer.pm (working copy)
@@ -26,7 +26,7 @@
use APR::Const -compile => ':common';
sub flatten_bb {
- my ($bb) = shift;
+ my($bb) = shift;
my $seen_eos = 0;
Index: t/filter/TestFilter/in_bbs_inject_header.pm
===================================================================
--- t/filter/TestFilter/in_bbs_inject_header.pm (revision 240189)
+++ t/filter/TestFilter/in_bbs_inject_header.pm (working copy)
@@ -56,7 +56,7 @@
# returns 1 if a bucket with a header was inserted to the $bb's tail,
# otherwise returns 0 (i.e. if there are no buckets to insert)
sub inject_header_bucket {
- my ($bb, $ctx) = @_;
+ my($bb, $ctx) = @_;
return 0 unless @{ $ctx->{buckets} };
Index: t/conf/modperl_extra.pl
===================================================================
--- t/conf/modperl_extra.pl (revision 240189)
+++ t/conf/modperl_extra.pl (working copy)
@@ -56,7 +56,7 @@
my $pool = Apache2::ServerUtil->server->process->pool;
my $project_root = canonpath
Apache2::ServerUtil::server_root_relative($pool, "..");
- my (@a, @b, @c);
+ my(@a, @b, @c);
for (@INC) {
if (m|^\Q$project_root\E|) {
m|blib| ? push @b, $_ : push @a, $_;
Index: t/response/TestApache/conftree.pm
===================================================================
--- t/response/TestApache/conftree.pm (revision 240189)
+++ t/response/TestApache/conftree.pm (working copy)
@@ -70,7 +70,7 @@
}
sub test_node {
- my ($data, $node) = @_;
+ my($data, $node) = @_;
ok $node->directive;
#Args can be null for argless directives
ok $node->args || 1;
@@ -81,7 +81,7 @@
}
sub traverse_tree {
- my ($sub, $data) = @_;
+ my($sub, $data) = @_;
my $node = Apache2::Directive::conftree();
while ($node) {
$sub->($data, $node);
Index: t/response/TestApache/subprocess.pm
===================================================================
--- t/response/TestApache/subprocess.pm (revision 240189)
+++ t/response/TestApache/subprocess.pm (working copy)
@@ -25,7 +25,7 @@
);
sub APACHE_TEST_CONFIGURE {
- my ($class, $self) = @_;
+ my($class, $self) = @_;
my $vars = $self->{vars};
@@ -86,7 +86,7 @@
# test: subproc's stdin -> stdout + list context
my $script = catfile $target_dir, "in_out.pl";
my $value = "my cool proc\r\n"; # must have \n for <IN>
- my ($in_fh, $out_fh, $err_fh) =
+ my($in_fh, $out_fh, $err_fh) =
$r->spawn_proc_prog($perl, [$script]);
print $in_fh $value;
(my $output = read_data($out_fh)) =~ s/[\r\n]{1,2}/\r\n/;
@@ -100,7 +100,7 @@
# test: subproc's stdin -> stderr + list context
my $script = catfile $target_dir, "in_err.pl";
my $value = "my stderr\r\n"; # must have \n for <IN>
- my ($in_fh, $out_fh, $err_fh) =
+ my($in_fh, $out_fh, $err_fh) =
$r->spawn_proc_prog($perl, [$script]);
print $in_fh $value;
(my $output = read_data($err_fh)) =~ s/[\r\n]{1,2}/\r\n/;
Index: t/response/TestAPR/perlio.pm
===================================================================
--- t/response/TestAPR/perlio.pm (revision 240189)
+++ t/response/TestAPR/perlio.pm (working copy)
@@ -226,7 +226,7 @@
for my $file ('MoonRise.jpeg', 'redrum.txt') {
my $in = catfile $dir, $file;
my $out = catfile $dir, "$file.out";
- my ($apr_content, $perl_content);
+ my($apr_content, $perl_content);
open my $rfh, "<:APR", $in, $r->pool
or die "Cannot open $in for reading: $!";
{
Index: t/response/TestModperl/post_utf8.pm
===================================================================
--- t/response/TestModperl/post_utf8.pm (revision 240189)
+++ t/response/TestModperl/post_utf8.pm (working copy)
@@ -46,7 +46,7 @@
require Encode; # since 5.8.0
$received = Encode::decode('utf8', $received);
# utf8::decode() doesn't work under -T
- my ($received_ascii, $received_utf8) = split /=/, $received;
+ my($received_ascii, $received_utf8) = split /=/, $received;
ok t_cmp($received_ascii, $expected_ascii, "ascii");
Index: t/response/TestCompat/conn_rec.pm
===================================================================
--- t/response/TestCompat/conn_rec.pm (revision 240189)
+++ t/response/TestCompat/conn_rec.pm (working copy)
@@ -21,14 +21,14 @@
plan $r, tests => 4;
Apache2::compat::override_mp2_api('Apache2::Connection::local_addr');
- my ($local_port, $local_addr) = sockaddr_in($c->local_addr);
+ my($local_port, $local_addr) = sockaddr_in($c->local_addr);
Apache2::compat::restore_mp2_api('Apache2::Connection::local_addr');
t_debug inet_ntoa($local_addr) . " :$local_port";
ok $local_port;
ok inet_ntoa($local_addr);
Apache2::compat::override_mp2_api('Apache2::Connection::remote_addr');
- my ($remote_port, $remote_addr) = sockaddr_in($c->remote_addr);
+ my($remote_port, $remote_addr) = sockaddr_in($c->remote_addr);
Apache2::compat::restore_mp2_api('Apache2::Connection::remote_addr');
t_debug inet_ntoa($remote_addr) . " :$remote_port";
ok $remote_port;
Index: t/response/TestCompat/apache_file.pm
===================================================================
--- t/response/TestCompat/apache_file.pm (revision 240189)
+++ t/response/TestCompat/apache_file.pm (working copy)
@@ -63,7 +63,7 @@
ok !Apache::File->new("$file.yeahright");
# tmpfile
- my ($tmpfile, $tmpfh) = Apache::File->tmpfile;
+ my($tmpfile, $tmpfh) = Apache::File->tmpfile;
t_debug "open tmpfile fh";
ok $tmpfh;
Index: t/response/TestDirective/perlmodule.pm
===================================================================
--- t/response/TestDirective/perlmodule.pm (revision 240189)
+++ t/response/TestDirective/perlmodule.pm (working copy)
@@ -25,7 +25,7 @@
}
sub APACHE_TEST_CONFIGURE {
- my ($class, $self) = @_;
+ my($class, $self) = @_;
my $vars = $self->{vars};
my $target_dir = catfile $vars->{documentroot}, 'testdirective';
Index: t/response/TestDirective/perlrequire.pm
===================================================================
--- t/response/TestDirective/perlrequire.pm (revision 240189)
+++ t/response/TestDirective/perlrequire.pm (working copy)
@@ -33,7 +33,7 @@
);
sub APACHE_TEST_CONFIGURE {
- my ($class, $self) = @_;
+ my($class, $self) = @_;
my $vars = $self->{vars};
my $target_dir = catfile $vars->{documentroot}, 'testdirective';
Index: t/lib/TestAPRlib/pool.pm
===================================================================
--- t/lib/TestAPRlib/pool.pm (revision 240189)
+++ t/lib/TestAPRlib/pool.pm (working copy)
@@ -70,7 +70,7 @@
# test: basic pool and sub-pool tests + implicit destroy of pool objects
{
{
- my ($pp, $sp) = both_pools_create_ok($table);
+ my($pp, $sp) = both_pools_create_ok($table);
}
both_pools_destroy_ok($table);
@@ -82,7 +82,7 @@
# test: explicitly destroying a parent pool should destroy its
# sub-pool
{
- my ($pp, $sp) = both_pools_create_ok($table);
+ my($pp, $sp) = both_pools_create_ok($table);
# destroying $pp should destroy the subpool $sp too
$pp->destroy;
@@ -96,7 +96,7 @@
# test: destroying a sub-pool before the parent pool
{
- my ($pp, $sp) = both_pools_create_ok($table);
+ my($pp, $sp) = both_pools_create_ok($table);
$sp->destroy;
$pp->destroy;
@@ -112,7 +112,7 @@
# the parent pool should have already destroyed the child pool, so
# the object is invalid
{
- my ($pp, $sp) = both_pools_create_ok($table);
+ my($pp, $sp) = both_pools_create_ok($table);
$pp->destroy;
$sp->destroy;
@@ -127,7 +127,7 @@
# call APR::Pool methods on the a subpool object which points to a
# destroyed pool
{
- my ($pp, $sp) = both_pools_create_ok($table);
+ my($pp, $sp) = both_pools_create_ok($table);
# parent pool destroys child pool
$pp->destroy;
@@ -211,7 +211,7 @@
# be at the same memory address.
{
- my ($pp2, $sp2);
+ my($pp2, $sp2);
{
my $pp = APR::Pool->new;
my $sp = $pp->new;
@@ -351,7 +351,7 @@
### $p->clear ###
{
- my ($pp, $sp) = both_pools_create_ok($table);
+ my($pp, $sp) = both_pools_create_ok($table);
$pp->clear;
# both pools should have run their cleanups
both_pools_destroy_ok($table);
Index: t/lib/TestAPRlib/table.pm
===================================================================
--- t/lib/TestAPRlib/table.pm (revision 240189)
+++ t/lib/TestAPRlib/table.pm (working copy)
@@ -138,7 +138,7 @@
# Filtering with anon sub
$filter_count=0;
$table->do(sub {
- my ($key,$value) = @_;
+ my($key,$value) = @_;
$filter_count++;
unless ($key eq chr($value+97)) {
die "arguments I recieved are bogus($key,$value)";
Index: t/lib/TestAPRlib/finfo.pm
===================================================================
--- t/lib/TestAPRlib/finfo.pm (revision 240189)
+++ t/lib/TestAPRlib/finfo.pm (working copy)
@@ -95,7 +95,7 @@
sub compare_with_perl {
- my ($finfo, $stat) = @_;
+ my($finfo, $stat) = @_;
# skip certain tests on Win32 and others
my %skip = ();
Index: lib/ModPerl/WrapXS.pm
===================================================================
--- lib/ModPerl/WrapXS.pm (revision 240189)
+++ lib/ModPerl/WrapXS.pm (working copy)
@@ -958,7 +958,7 @@
# resolve situations where there is more than one module containing
# the same method. Inheritance is supported.
sub lookup_method {
- my ($method, $object) = @_;
+ my($method, $object) = @_;
unless (defined $method) {
my $hint = "No 'method' argument was passed\n";
@@ -969,7 +969,7 @@
$method =~ s/.+:://;
if (exists $methods_compat->{$method}) {
- my ($replacement, $comment) = @{$methods_compat->{$method}};
+ my($replacement, $comment) = @{$methods_compat->{$method}};
my $hint = "'$method' is not a part of the mod_perl 2.0 API\n";
$comment = length $comment ? " $comment\n" : "";
@@ -981,7 +981,7 @@
# if fully qualified don't look up its container
return $hint if $replacement =~ /::/;
- my ($modules_hint, @modules) = lookup_method($replacement, $object);
+ my($modules_hint, @modules) = lookup_method($replacement, $object);
return $hint . $modules_hint;
}
elsif (!exists $methods->{$method}) {
@@ -1039,7 +1039,7 @@
# what methods are contained in the passed module name
sub lookup_module {
- my ($module) = shift;
+ my($module) = shift;
unless (defined $module) {
my $hint = "no 'module' argument was passed\n";
@@ -1074,7 +1074,7 @@
# what methods can be invoked on the passed object (or its reference)
sub lookup_object {
- my ($object) = shift;
+ my($object) = shift;
unless (defined $object) {
my $hint = "no 'object' argument was passed\n";
Index: lib/ModPerl/CScan.pm
===================================================================
--- lib/ModPerl/CScan.pm (revision 240189)
+++ lib/ModPerl/CScan.pm (working copy)
@@ -25,7 +25,7 @@
$ModPerl::CScan::VERSION = '0.75';
-my (%keywords,%style_keywords);
+my(%keywords,%style_keywords);
for (qw(asm auto break case char continue default do double else enum
extern float for fortran goto if int long register return short
sizeof static struct switch typedef union unsigned signed while void
volatile)) {
@@ -179,7 +179,7 @@
sub defines_maybe {
my $file = shift;
- my ($mline,$line,%macros,%macrosargs,$sym,$args);
+ my($mline,$line,%macros,%macrosargs,$sym,$args);
open(C, $file) or die "Cannot open file $file: $!\n";
while (not eof(C) and $line = <C>) {
next unless
@@ -211,7 +211,7 @@
sub defines_full {
my $Cpp = $_[3];
- my ($mline,$line,%macros,%macrosargs,$sym,$args);
+ my($mline,$line,%macros,%macrosargs,$sym,$args);
# save the old cppflags and add the flag for only ouputting macro definitions
my $old_cppstdin = $Cpp->{'cppstdin'};
@@ -252,7 +252,7 @@
sub typedef_chunks { # Input is toplevel, output: starts and ends
my $txt = shift;
pos $txt = 0;
- my ($b, $e, @out);
+ my($b, $e, @out);
while ($txt =~ /\btypedef\b/g) {
push @out, pos $txt;
$txt =~ /(?=;)|\Z/g;
@@ -264,7 +264,7 @@
sub struct_chunks {
my $txt = shift;
pos $txt = 0;
- my ($b, $e, @out);
+ my($b, $e, @out);
while ($txt =~ /\b(?=struct\s*(\w*\s*)?\{)/g) {
push @out, pos $txt;
$txt =~ /(?=;)|\Z/g;
@@ -276,7 +276,7 @@
sub typedefs_whited { # Input is sanitized text, and list of beg/end.
my @lst = @{$_[1]};
my @out;
- my ($b, $e);
+ my($b, $e);
while ($b = shift @lst) {
$e = shift @lst;
push @out, whited_decl($_[2], substr $_[0], $b, $e - $b);
@@ -287,7 +287,7 @@
sub structs_whited {
my @lst = @{$_[1]};
my @out;
- my ($b, $e, $in);
+ my($b, $e, $in);
while ($b = shift @lst) {
$e = shift @lst;
$in = substr $_[0], $b, $e - $b;
@@ -298,8 +298,8 @@
}
sub typedef_texts {
- my ($txt, $chunks) = (shift, shift);
- my ($b, $e, $in, @out);
+ my($txt, $chunks) = (shift, shift);
+ my($b, $e, $in, @out);
my @in = @$chunks;
while (($b, $e) = splice @in, 0, 2) {
$in = substr($txt, $b, $e - $b);
@@ -311,7 +311,7 @@
}
sub typedef_hash {
- my ($typedefs, $whited) = (shift,shift);
+ my($typedefs, $whited) = (shift,shift);
my %out;
loop:
@@ -324,7 +324,7 @@
# Determine whether the new thingies are inside parens
$wh =~ /,/g;
my $p = pos $wh;
- my ($s, $e);
+ my($s, $e);
if (matchingbrace($wh)) { # Inside. Easy part: just split on
/,/...
$e = pos($wh) - 1;
$s = $e;
@@ -358,11 +358,11 @@
# Now: need to split $td based on commas in $wh!
# And need to split each chunk of $td based on word in the chunk of $wh!
my $td_decls = substr($td, $s, $e - $s);
- my ($pre, $post) = (substr($td, 0, $s), substr($td, $e));
+ my($pre, $post) = (substr($td, 0, $s), substr($td, $e));
my $wh_decls = substr($wh, $s, $e - $s);
my @wh_decls = split /,/, $wh_decls;
my $td_s = 0;
- my (@td_decl, @td_pre, @td_post, @td_word);
+ my(@td_decl, @td_pre, @td_post, @td_word);
for my $wh_d (@wh_decls) {
my $td_d = substr $td, $td_s, length $wh_d;
push @td_decl, $td_d;
@@ -534,7 +534,7 @@
# What remains now consists of variable and function declarations,
# and inline functions.
$in =~ /(?=\S)/g;
- my ($b, $e, $b1, $e1, @inlines, @decls, @mdecls, @fdecls, @vdecls);
+ my($b, $e, $b1, $e1, @inlines, @decls, @mdecls, @fdecls, @vdecls);
$b = pos $in;
my $chunk;
while (defined($b) && $b != length $in) {
@@ -767,10 +767,10 @@
# basing on this argument.
sub do_declaration {
- my ($decl, $typedefs, $keywords, $argnum) = @_;
+ my($decl, $typedefs, $keywords, $argnum) = @_;
$decl =~ s/;?\s*$//;
- my ($type, $typepre, $typepost, $ident, $args, $w, $pos, $repeater);
+ my($type, $typepre, $typepost, $ident, $args, $w, $pos, $repeater);
$decl =~ s/[\r\n]\s*/ /g;
#warn "DECLAR [$decl][$argnum]\n";
$decl =~ s/^\s*__extension__\b\s*//;
@@ -848,10 +848,10 @@
}
sub do_declaration1 {
- my ($decl, $typedefs, $keywords, $argnum) = @_;
+ my($decl, $typedefs, $keywords, $argnum) = @_;
$decl =~ s/;?\s*$//;
#warn "DECLARO [$decl][$argnum]\n";
- my ($type, $typepre, $typepost, $ident, $args, $w, $pos, $repeater);
+ my($type, $typepre, $typepost, $ident, $args, $w, $pos, $repeater);
$pos = 0;
while ($decl =~ /(\w+)/g and ($typedefs->{$1} or $keywords->{$1})) {
$w = $1;
@@ -932,7 +932,7 @@
sub new {
die "usage: C::Preprocessed->new(filename[, defines[, includes[, cpp]]])"
if @_ < 2 or @_ > 5;
- my ($class, $filename, $Defines, $Includes, $Cpp)
+ my($class, $filename, $Defines, $Includes, $Cpp)
= (shift, shift, shift, shift, shift);
$Cpp ||= \%Config::Config;
my $filedir = dirname $filename || '.';
Index: lib/ModPerl/BuildMM.pm
===================================================================
--- lib/ModPerl/BuildMM.pm (revision 240189)
+++ lib/ModPerl/BuildMM.pm (working copy)
@@ -257,7 +257,7 @@
next if WIN32 || CYGWIN;
# manify while we're at it
- my (undef, $man, undef) = $blib =~ m!(blib/lib/)(.*)(\.pm)!;
+ my(undef, $man, undef) = $blib =~ m!(blib/lib/)(.*)(\.pm)!;
$man =~ s!/!::!g;
push @target,
Index: lib/Apache2/PerlSections.pm
===================================================================
--- lib/Apache2/PerlSections.pm (revision 240189)
+++ lib/Apache2/PerlSections.pm (working copy)
@@ -86,7 +86,7 @@
# Apache2::ReadConfig:: directly in <Perl> sections
foreach my $pack ($self->package, $self->SPECIAL_PACKAGE) {
#XXX: Shamelessly borrowed from Devel::Symdump;
- while (my ($key, $val) = each(%{ *{"$pack\::"} })) {
+ while (my($key, $val) = each(%{ *{"$pack\::"} })) {
#We don't want to pick up stashes...
next if ($key =~ /::$/);
local (*ENTRY) = $val;
Index: lib/Apache2/PerlSections/Dump.pm
===================================================================
--- lib/Apache2/PerlSections/Dump.pm (revision 240189)
+++ lib/Apache2/PerlSections/Dump.pm (working copy)
@@ -43,7 +43,7 @@
}
sub store {
- my ($class, $filename) = @_;
+ my($class, $filename) = @_;
require IO::File;
my $fh = IO::File->new(">$filename") or die "can't open $filename $!\n";
Index: lib/Apache2/Build.pm
===================================================================
--- lib/Apache2/Build.pm (revision 240189)
+++ lib/Apache2/Build.pm (working copy)
@@ -283,12 +283,12 @@
}
sub should_build_apache {
- my ($self) = @_;
+ my($self) = @_;
return $self->{MP_USE_STATIC} ? 1 : 0;
}
sub configure_apache {
- my ($self) = @_;
+ my($self) = @_;
unless ($self->{MP_AP_CONFIGURE}) {
error "You specified MP_USE_STATIC but did not specify the " .
@@ -1056,7 +1056,7 @@
# ap_exp_includedir is where apache is going to install its
# headers to
sub ap_exp_includedir {
- my ($self) = @_;
+ my($self) = @_;
return $self->{ap_exp_includedir} if $self->{ap_exp_includedir};
@@ -1075,7 +1075,7 @@
}
sub install_headers_dir {
- my ($self) = @_;
+ my($self) = @_;
if ($self->should_build_apache) {
return $self->ap_exp_includedir();
}
@@ -1087,7 +1087,7 @@
# where apr-config and apu-config reside
sub apr_bindir {
- my ($self) = @_;
+ my($self) = @_;
$self->apr_config_path unless $self->{apr_bindir};
$self->{apr_bindir};
@@ -1141,7 +1141,7 @@
}
sub apru_config_path {
- my ($self, $what) = @_;
+ my($self, $what) = @_;
my $key = "${what}_config_path"; # apr_config_path
my $mp_key = "MP_" . uc($what) . "_CONFIG"; # MP_APR_CONFIG
@@ -1208,7 +1208,7 @@
}
sub apr_includedir {
- my ($self) = @_;
+ my($self) = @_;
return $self->{apr_includedir}
if $self->{apr_includedir} and -d $self->{apr_includedir};
@@ -1704,7 +1704,7 @@
my $self = shift;
# The MP_APR_LIB will be installed into MP_AP_PREFIX/lib
# for use by 3rd party xs modules
- my ($dir, $lib) = $self->mp_apr_blib();
+ my($dir, $lib) = $self->mp_apr_blib();
$lib =~ s[^lib(\w+)$Config{lib_ext}$][$1];
$dir = Win32::GetShortPathName($dir);
return qq{ -L$dir -l$lib };
@@ -1712,7 +1712,7 @@
sub mp_apr_lib_cygwin {
my $self = shift;
- my ($dir, $lib) = $self->mp_apr_blib();
+ my($dir, $lib) = $self->mp_apr_blib();
$lib =~ s[^lib(\w+)$Config{lib_ext}$][$1];
my $libs = "-L$dir -l$lib";
Index: lib/Apache2/porting.pm
===================================================================
--- lib/Apache2/porting.pm (revision 240189)
+++ lib/Apache2/porting.pm (working copy)
@@ -57,7 +57,7 @@
croak "Undefined subroutine $AUTOLOAD called"
unless defined $method && exists $avail_methods{$method};
- my ($hint, @modules) =
+ my($hint, @modules) =
ModPerl::MethodLookup::lookup_method($method, @_);
$hint ||= "Can't find method $AUTOLOAD";
croak $hint;
Index: lib/Apache2/Status.pm
===================================================================
--- lib/Apache2/Status.pm (revision 240189)
+++ lib/Apache2/Status.pm (working copy)
@@ -87,7 +87,7 @@
use constant CPAN_SEARCH => 'http://search.cpan.org/search?mode=module;query';
sub install_hint {
- my ($module) = @_;
+ my($module) = @_;
return qq{<p>Please install the } .
qq{<a href="@{[CPAN_SEARCH]}=$module">$module</a> module.</p>};
}
@@ -308,7 +308,7 @@
}
sub status_env {
- my ($r) = shift;
+ my($r) = shift;
my @retval = ("<p>\n");
Index: lib/Apache2/compat.pm
===================================================================
--- lib/Apache2/compat.pm (revision 240189)
+++ lib/Apache2/compat.pm (working copy)
@@ -234,7 +234,7 @@
# it expects a list of fully qualified functions, like
# "Apache2::RequestRec::finfo"
sub override_mp2_api {
- my (@subs) = @_;
+ my(@subs) = @_;
for my $sub (@subs) {
unless (exists $overridable_mp2_api{$sub}) {
@@ -255,7 +255,7 @@
# restore_mp2_api does the opposite of override_mp2_api(), it removes
# the overriden API and restores the original mod_perl 2.0 API
sub restore_mp2_api {
- my (@subs) = @_;
+ my(@subs) = @_;
for my $sub (@subs) {
unless (exists $overridable_mp2_api{$sub}) {
@@ -466,7 +466,7 @@
}
sub send_http_header {
- my ($r, $type) = @_;
+ my($r, $type) = @_;
# since send_http_header() in mp1 was telling mod_perl not to
# parse headers and in mp2 one must call $r->content_type($type) to
@@ -706,7 +706,7 @@
# cannot forward @_ to open() because of its prototype
if (@_ > 1) {
- my ($mode, $file) = @_;
+ my($mode, $file) = @_;
CORE::open $self, $mode, $file;
}
else {
Index: ModPerl-Registry/lib/ModPerl/RegistryCooker.pm
===================================================================
--- ModPerl-Registry/lib/ModPerl/RegistryCooker.pm (revision 240189)
+++ ModPerl-Registry/lib/ModPerl/RegistryCooker.pm (working copy)
@@ -325,7 +325,7 @@
sub namespace_from_filename {
my $self = shift;
- my ($volume, $dirs, $file) =
+ my($volume, $dirs, $file) =
File::Spec::Functions::splitpath($self->{FILENAME});
my @dirs = File::Spec::Functions::splitdir($dirs);
return join '_', grep { defined && length } $volume, @dirs, $file;
Index: util/methodlookup_check.pl
===================================================================
--- util/methodlookup_check.pl (revision 240189)
+++ util/methodlookup_check.pl (working copy)
@@ -12,7 +12,7 @@
# methods/classes ModPerl::MethodLookup knows about
my %known = ();
for (ModPerl::MethodLookup::avail_methods()) {
- my ($modules_hint, @modules) = ModPerl::MethodLookup::lookup_method($_);
+ my($modules_hint, @modules) = ModPerl::MethodLookup::lookup_method($_);
$known{$_} = { map {$_ => 1} @modules};
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
