Stas Bekman wrote: > At the moment Child(Init|Exit) phases are of type VOID, i.e. any > failures are ignored, which sucks, since you now can't do any reliable > initialization in the child init phase (e.g. let's say Apache::DBI's > child_init phase fails).
a call to die() shouldn't be ignored. that's the typical way to exit from void phases. > How about making it RUN_ALL instead? The > immediate gain is that errors are now logged. I don't see any problems > with backwards compatibility, besides ChildInit phases needing to return > OK or DECLINED, but most likely there were all doing so anyway. what's the rationale for making this phase RUN_ALL but leaving the other VOID phases as is? if die() works then there is an exit strategy for the VOID phases. if die() isn't logged, that's something we ought to fix, not necessarily by changing the runtime prototype to RUN_ALL, though. also, I'm in favor of keeping these phases programmatically aligned with httpd. > > The only problem I have is how to prevent from Apache to continue on > failure. Any ideas? I'm not sure that it makes sense to halt apache on failure in these phases. you want to shut httpd down if a PerlChildExitHandler fails? these aren't part of startup processing so I don't see how they could prevent apache from starting. --Geoff --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
