Philip M. Gollucci wrote:
Stas Bekman wrote:
[EMAIL PROTECTED] wrote:
code duplication detected :) whenever you find yourself duplicating
code you should immediately consider refactoring. Otherwise the future
won't be too good... :)
This code should live in Apache::TestConfig and used here as a
function call.
I saw that actually.
ModPerl::Config::as_string and Apache::TestConfig::as_string are
remarkably but not quite similiar.
Please note that I've quoted the specific part of the code I was talking
about. That part is remarkable indentical :) Just go for lower granularity.
I going to get to mentioning that .... I was thinking pretty much all of
it should be in in A-T and ModPerl::Config::as_string() should just be a
set of function calls to the A-T implementations.
+1
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://mailchannels.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
