Re: httpd 2.3.01 and t/modules/proxy.t

[Joe Orton]

On Mon, Sep 12, 2005 at 03:42:28AM -0400, Philip M. Gollucci wrote:
> Philip M. Gollucci wrote:
> >What happens is:
> >requested: http://localhost:8536/TestModules__proxy
> >"proxied to": http://localhost:8536/TestModules__proxy_real
> >
> >
> >But if I directly request
> >http://localhost:8536/TestModules__proxy_real
> 
> Assume 8536 == 8537 .. sorry for the typo

This was discussed a while back.  I don't think it makes sense for 
mod_perl to set r->proxyreq to anything other than PROXYREQ_REVERSE; 
this fixes the failure, Geoff may disagree still though ;)

Index: xs/Apache2/RequestRec/Apache2__RequestRec.h
===================================================================
--- xs/Apache2/RequestRec/Apache2__RequestRec.h (revision 291092)
+++ xs/Apache2/RequestRec/Apache2__RequestRec.h (working copy)
@@ -58,14 +58,14 @@
                                    r->parsed_uri.port : 
                                    ap_default_port(r))))
     {
-        retval = r->proxyreq = 1;
+        retval = r->proxyreq = PROXYREQ_REVERSE;
         r->uri = r->unparsed_uri;
         /* else mod_proxy will segfault */
         r->filename = apr_pstrcat(r->pool, "modperl-proxy:", r->uri, NULL);
     }
 
     if (val) {
-        r->proxyreq = SvIV(val);
+        r->proxyreq = SvIV(val) ? PROXYREQ_REVERSE : 0;
     }
 
     return retval;

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]