Joe Schaefer wrote:
Steve Hay <[EMAIL PROTECTED]> writes:
#define PerlLIO_link(oldname, newname) link((oldname), (newname))
#define link win32_link
Ew.
[...]
I'm sure not where this needs fixing -- Perl, mod_perl, or libapreq --
but now would be a good time whichever of those it is to be!
IMO submit a tested patch to libapreq's Param.xs that does this
(where MY_PLATFORM is suitably defined to match the above):
#ifdef MY_PLATFORM
#undef PerlLIO_link
#define PerlLIO_link(oldname, newname) win32_link(oldname, newname)
#endif
OK, patch attached does exactly that. With this patch in place
libapreq2-2.07-rc1 now builds without error, and all tests pass too.
(This is using perl-5.8.7, apache-2.0.54 and mod_perl-2.0.1 on WinXP
with VC++ 6.)
------------------------------------------------
Radan Computational Ltd.
The information contained in this message and any files transmitted with it are
confidential and intended for the addressee(s) only. If you have received this
message in error or there are any problems, please notify the sender
immediately. The unauthorized use, disclosure, copying or alteration of this
message is strictly forbidden. Note that any views or opinions presented in
this email are solely those of the author and do not necessarily represent
those of Radan Computational Ltd. The recipient(s) of this message should check
it and any attached files for viruses: Radan Computational will accept no
liability for any damage caused by any virus transmitted by this email.
--- glue/perl/xsbuilder/APR/Request/Param/Param.xs.orig 2005-08-20
20:42:10.000000000 +0100
+++ glue/perl/xsbuilder/APR/Request/Param/Param.xs 2005-10-05
09:20:32.199348600 +0100
@@ -1,3 +1,13 @@
+/* On Win32 without PERL_IMPLICIT_SYS, PerlLIO_link is #defined as link, which
+ * in turn is #defined as win32_link, but mp2's modperl_perl_unembed.h #undefs
+ * link, leaving link as an unresolved symbol when linking Param.dll. */
+#ifdef WIN32
+#ifndef PERL_IMPLICIT_SYS
+#undef PerlLIO_link
+#define PerlLIO_link(oldname, newname) win32_link(oldname, newname)
+#endif
+#endif
+
MODULE = APR::Request::Param PACKAGE = APR::Request::Param
SV *
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
