Geoffrey Young wrote: >>- plan $r, tests => 9; >>+ # make it ok to call ok() here while plan()ing elsewhere >>+ Apache::Test::init_test_pm($r); >>+ $Test::ntest = 1 + (22 * ($r->args - 1)); >>+ $Test::planned = 22; > > and of course everyone is wondering what this is. it would help if my > (third) patch actually included all the bits and pieces I put together for > this. > > part of the issue is that t/modperl/pnotes.t is in the svn ignore list, so > svn status didn't pick it up... > > anyway, sorry for the flood of spam, but _this_ should be good to go. > really, I should have caught both mistakes when philip said things looked > good but the first few iterations of the patch didn't include the real > functionality :) guess I'm having a significant amount of brane > deterioration from not working on this stuff as much as I ought... > > so, testing on a battery of platforms appreciated.
All tests pass for me on various platforms, but...
Where do you cleanup HV *modperl_config_con_t->pnotes ? Looks to me
like you are leaking it. You'd need something similar to what we
are doing for request pnotes:
apr_status_t modperl_config_request_cleanup(pTHX_ request_rec *r)
{
[...]
if (rcfg->pnotes) {
SvREFCNT_dec(rcfg->pnotes);
rcfg->pnotes = Nullhv;
}
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
signature.asc
Description: OpenPGP digital signature
