Philip M. Gollucci wrote: > Hi all, > > If you've been following bnicholes rework of AAA yet again, its looking > good, but thinks have moved and mod_perl2 no longer compiles against the > httpd-trunk.
yeah. fwiw, I started down this road a while ago, but it seemed like aaa was still too much of a moving target to wedge in. > > I believe I can fix this one, but I've got a few questions. > > First, I need to add the missing include to modperl_constants.[ch] or > modperl_const.h -- I picked modperl_constants.c because AFAIK, they are > not referenced outside that file. (diff at end) IIRC its mod_auth.h that you need, and yeah, I'd stick it into modperl_apache_includes.h along with all the other includes. but more on that below. > > My current problem is how do I tweak the generation of > xs/maps/apache2_functions.map > xs/tables/current/Apache2/FunctionTable.pm > > to be conditional on the function list based on httpd version ? I'd suggest using modperl_apache_compat.c. traditionally, we've added new functions to the generation code unconditionally, then used modperl_apache_compat.c to ifdef stub code for older apaches that don't contain the functionality. > > Obviously the function has to be there for pre 2.3.0 and not for 2.3.0+ right. so, I'd treat 2.3.0+ as the new trunk we should target, placing code we need for that right in our trunk. then use the compat module to make sure older httpd versions still compile and work. you can see the svn history to see how it used to work. so, I think we have the functions covered. the sole excpetion should be the mod_auth.h header file, which doesn't really fit. I guess marking it with BACK_COMPAT_MARKER in modperl_apache_includes.h should allow us to find it in a few years when we stop supporting 2.0.54 :) > > On another note, 'Order', 'Allow', 'Deny' are disappearing too and > mod_auth_comat.h was added for back compat. right. anyway, HTH --Geoff --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
