On Tue, 6 Jun 2006, Steve Hay wrote:
Steve Hay wrote:
Randy Kobes wrote:
Thanks very much for the explanation, Steve - that makes
sense. So as was mentioned earlier, this problem probably
won't be encountered by the majority of Win32 users,
who will be unpacking a CPAN distribution. It is
annoying for svn users though who may encounter this
problem - would the following patch be OK, which uses
the generated httpd.conf as the file?
The patch works OK for me (and, as you say, we don't need the utime()
call any more either.)
Randy, I see that you applied your patch to change the file used in the
finfo tests, but you didn't remove the utime() call. Was there any
particular reason why not, or just an oversight?
I can't see any point to keeping it now: the httpd.conf file should be
up-to-date (i.e. in the same DST season), and if it isn't then the
utime() call will only fix up the mtime, not the ctime, which is
probably more confusing than helpful.
With the attached patch, I currently have all tests successful.
Hi Steve,
That was an oversight - you're right that leaving it in
there is confusing. Thanks for the patch - this was
committed as revision 412118.
--
best regards,
Randy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
