You're right. -d seems better.

Index: BuildOptions.pm
===================================================================
--- BuildOptions.pm (revision 452813)
+++ BuildOptions.pm (working copy)
@@ -121,6 +121,11 @@
                     require Win32;
                     $val = Win32::GetShortPathName($val);
                 }
+
+                if (!$val || !-d $val) {
+                    error "MP_AP_PREFIX must point to a valid directory.";
+                    die "\n";
+                }
             }

             if ($table->{$key}->{append}){



"Paul Johnson" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> On Wed, Oct 04, 2006 at 01:49:21PM +0300, Nikolay Ananiev wrote:
>
> > This patch adds a nice error message.
> >
> > Index: BuildOptions.pm
> > ===================================================================
> > --- BuildOptions.pm (revision 452813)
> > +++ BuildOptions.pm (working copy)
> > @@ -121,6 +121,11 @@
> >                      require Win32;
> >                      $val = Win32::GetShortPathName($val);
> >                  }
> > +
> > +                if (!$val || !-e $val) {
> > +                    error "MP_AP_PREFIX must point to a valid
directory.";
> > +                    die "\n";
> > +                }
>
> Perhaps -d instead?
>
> --
> Paul Johnson - [EMAIL PROTECTED]
> http://www.pjcj.net




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to