Philip M. Gollucci wrote:
if (defined $val && defined *ENTRY{ARRAY}) {
- push @{$self->{symbols}}, [$key, [EMAIL PROTECTED];
+ unless (exists
$directives_seen_back{"$key-$ENTRY[0]"}) {
+ $directives_seen_back{"$key-$ENTRY[0]"} = 1;
+ push @{$self->{symbols}}, [$key, [EMAIL PROTECTED];
+ }
}
It helps to use the correct variables. This is what happens at 4:30am....
And check it out, I'm even going to only have to commit this one once!
http://svn.apache.org/viewvc?view=rev&revision=482625
Cool! I'm not sure whether this is related, but now this test breaks:
t/directive/perldo....1..22
# Running under perl version 5.008007 for linux
# Current time local: Thu Dec 7 11:05:42 2006
# Current time GMT: Thu Dec 7 19:05:42 2006
# Using Test.pm version 1.25
# Using Apache/Test.pm version 1.30
# expected: yes
# received: yes
ok 1
# testing : __PACKAGE__
# expected: (?-xism:t::conf::extra_last_conf::line_\d+$)
# received:
Apache2::ReadConfig::home::stas::apache_org::mp2_svn::t::conf::extra_last_conf::line_32
ok 2
ok 3
ok 4
# expected: PerlSection
# received: PerlSection
ok 5
# testing : Tied %Location
# expected: TIED
# received: TIED
ok 6
# expected: yes
# received: yes
ok 7
# testing : $0
# expected: (?-xism:extra.last.conf)
# received: /home/stas/apache.org/mp2-svn/t/conf/extra.last.conf
ok 8
# testing : __FILE__
# expected: (?-xism:extra.last.conf)
# received: /home/stas/apache.org/mp2-svn/t/conf/extra.last.conf
ok 9
ok 10
# testing : $0
# expected: -e
# received: /home/stas/httpd/prefork/bin/httpd
ok 11
# testing : $0
# expected: (?i-xsm:httpd)
# received: /home/stas/httpd/prefork/bin/httpd
ok 12
# testing : Include
# expected: 1
# received: 1
ok 13
# testing : Apache2::PerlSections->dump
# expected: (?-xism:__END__)
# received: $Location{'/perl_sections_saved'} = {
# 'AuthName' => 'PerlSection'
# };
# $Location{'/tied'} = 'TIED';
# $Include = '/home/stas/apache.org/mp2-svn/t/conf/perlsection.conf';
# $Location{'/perl_sections_readconfig'} = {
# 'AuthType' => 'Basic',
# 'PerlAuthenHandler' =>
'TestHooks::authen_basic',
# 'AuthName' => 'PerlSection',
# 'PerlInitHandler' =>
'ModPerl::Test::add_config'
# };
# @PerlConfig = (
# 'Alias /perl_sections_perlconfig_scalar
/home/stas/apache.org/mp2-svn/t/htdocs'
# );
# @PerlConfig = (
# 'Alias /perl_sections_perlconfig_scalar1
/home/stas/apache.org/mp2-svn/t/htdocs',
# 'Alias /perl_sections_perlconfig_scalar2
/home/stas/apache.org/mp2-svn/t/htdocs'
# );
# @PerlConfig = (
# 'Alias /perl_sections_perlconfig_array1
/home/stas/apache.org/mp2-svn/t/htdocs',
# 'Alias /perl_sections_perlconfig_array2
/home/stas/apache.org/mp2-svn/t/htdocs'
# );
# 1;
# __END__
ok 14
# testing : PerlSections dump syntax check
# expected:
# received:
ok 15
# expected: (?-xism:perlsection.conf)
# received: /home/stas/apache.org/mp2-svn/t/conf/perlsection.conf
ok 16
ok 17
# testing : $PerlConfig
# expected: 1
# received:
not ok 18
# testing : $PerlConfig
# expected: 1
# received:
not ok 19
# testing : $PerlConfig
# expected: 1
# received:
not ok 20
# testing : @PerlConfig
# expected: 1
# received:
not ok 21
# testing : @PerlConfig
# expected: 1
# received:
not ok 22
FAILED tests 18-22
Failed 5/22 tests, 77.27% okay
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
t/directive/perldo.t 22 5 22.73% 18-22
Failed 1/1 test scripts, 0.00% okay. 5/22 subtests failed, 77.27% okay.
server foobar.mailchannels.com:8529 shutdown
error running tests (please examine t/logs/error_log)
--
_____________________________________________________________
Stas Bekman mailto:[EMAIL PROTECTED] http://stason.org/
MailChannels: Reliable Email Delivery http://mailchannels.com
The "Practical mod_perl" book http://modperlbook.org/
http://www.linkedin.com/in/stasbekman http://perl.apache.org/
http://stason.org/photos/gallery/ [* best photos here *]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
