Steve Hay wrote: > The attached patch stops mod_perl-1.x from calling av_undef() on a NULL AV*.
Most certainly a *bad* thing IMO. > This fixes some horrible nastiness when using bleadperl, which no longer > returns early from av_undef() in the case that the AV* is NULL as of > perl change #26513. Ouch. > Would someone please be kind enough to take a quick look and +1 it if > looks OK before I commit? Applied, built and tested just fine on my side. Only minor comment would be to consider writing a macro around this to avoid duplicating the code. #define MP_safe_av_undef(av) Or something like that. For bonus points, only enable the workaround for affected versions of perl and fallback to the original av_undef() otherwise. ------------------------------------------------------------------------ Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5 http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
signature.asc
Description: OpenPGP digital signature
