Geoffrey Young wrote: > -------- Original Message -------- > Subject: MP2: Patch to fix dynamic loading under OpenBSD (Was: Patches > for two problems under OpenBSD) > Date: Sun, 10 Jun 2007 20:38:53 +0200 > From: Simon Bertrang <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > References: <[EMAIL PROTECTED]> > > On Sat, Jun 09, 2007 at 08:22:30PM +0200, Simon Bertrang wrote: >> Hi, >> when porting libapreq2 to OpenBSD we noticed a problem with a workaround >> that doesn't apply anymore (APR.pm):
Since what release of OpenBSD does this fix become irrelevant ? >> $OpenBSD: patch-xs_APR_APR_APR_pm,v 1.1 2007/06/09 16:02:04 martynas Exp $ >> --- xs/APR/APR/APR.pm.orig Mon Nov 20 01:31:02 2006 >> +++ xs/APR/APR/APR.pm Sat Jun 9 18:10:04 2007 >> @@ -23,7 +23,7 @@ our @ISA = qw(DynaLoader); >> # XXX: see xs/ModPerl/Const/Const.pm for issues of using 0x01 >> use Config (); >> use constant DL_GLOBAL => >> - ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' && $^O ne 'openbsd' ) ? 0x01 : >> 0x0; >> + ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' ) ? 0x01 : 0x0; >> sub dl_load_flags { DL_GLOBAL } >> >> unless (defined &APR::XSLoader::BOOTSTRAP) { >> Is it safe enough to assume the older affected OpenBSDs versions have all upgraded ? Or wouldn't it be easier to do someting like include detection of the affected versions, and keep it working in both cases ? ------------------------------------------------------------------------ Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5 http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
signature.asc
Description: OpenPGP digital signature