On Fri 22 Feb 2008, Philippe M. Chiasson wrote: > - parms.path = path; > + parms.path = apr_pstrdup(p, path);
Yes, Philippe, you are right. In current modperl there are 3 ways to get to modperl_config_insert(): - $r->add_config via modperl_config_insert_request - $s->add_config via modperl_config_insert_server - $parms->add_config via modperl_config_insert_parms Since $parms->path is read-only and modperl_config_insert_server passes a NULL as path there is only one way to have a custom path passed to modperl_config_insert, modperl_config_insert_request. So patching $r->add_config only would be sufficient, as well. Nevertheless, fixing it in modperl_config_insert is probably the best way regarding future changes. Torsten --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
