Reviewed, tested, and committed.
r661903
Geoffrey Young wrote:
-------- Original Message --------
Subject: [rt.cpan.org #36305] Overridden get_basic_credentials broken w/
NTLM Authentication
Date: Fri, 30 May 2008 13:43:17 -0400
From: RFRANKEL via RT <[EMAIL PROTECTED]>
Reply-To: [EMAIL PROTECTED]
To: undisclosed-recipients:;
References: <[EMAIL PROTECTED]>
Fri May 30 13:43:16 2008: Request 36305 was acted upon.
Transaction: Ticket created by RFRANKEL
Queue: Apache-Test
Subject: Overridden get_basic_credentials broken w/ NTLM
Authentication
Broken in: 1.29, 1.30
Severity: Important
Owner: Nobody
Requestors: [EMAIL PROTECTED]
Status: new
Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=36305 >
Apache::TestRequest::get_basic_credentials dies when accessing a realm
using mod_ntlm for authentication. The reason is that $realm is undefined.
Patch to fix below:
--- TestRequest.pm~ 2007-11-14 01:44:36.000000000 -0500
+++ TestRequest.pm 2008-05-30 11:35:57.681722000 -0400
@@ -260,7 +260,7 @@
my($self, $realm, $uri, $proxy) = @_;
for ($realm, '__ALL__') {
- next unless $credentials{$_};
+ next unless $_ && $credentials{$_};
return @{ $credentials{$_} };
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
