2010/3/31 Torsten Förtsch <torsten.foert...@gmx.net>: > On Wednesday 31 March 2010 16:43:04 Torsten Förtsch wrote: >> I believe the IoFLUSH_off in the override function can be omitted since >> this is standard for a new handle. >> > This appears to be true. This is now the final version of the patch. Are there > any objections against applying it to trunk?
I was able to review some of what you posted yesterday but still haven't had enough time to digest the changes. It would make it much, much easier if you submitted the patches inline for review so that others can comment inline. http://perl.apache.org/docs/2.0/devel/help/help.html#Submitting_Patches "Note that we prefer the patches inlined into an email. This makes easier to comment on them." Can you repost the latest patch inline so that interested parties can add comments and understand what is going on in there? I know that only a few people understand the innards of mod_perl with XS magic, but just getting it out there will help with that and the more eyes on the code the better. > > Torsten Förtsch > > -- > Need professional modperl support? Hire me! (http://foertsch.name) > > Like fantasy? http://kabatinte.net > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org > For additional commands, e-mail: dev-h...@perl.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
