On 10-06-14 22:47 , Philip M. Gollucci wrote: > On 06/14/10 19:46, Philippe M. Chiasson wrote: >> On 10-06-14 15:16 , Fred Moyer wrote: >>> I put this patch together as part of the todo list for 2.0.5. Gozer, >>> is this what we are looking for? >>> >>> Index: Makefile.PL >>> =================================================================== >>> --- Makefile.PL (revision 953555) >>> +++ Makefile.PL (working copy) >>> @@ -786,6 +786,8 @@ >>> $(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \ >>> t/TEST -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES) >>> cd ModPerl-Registry && $(MAKE) test >>> + cd Apache-Reload && $(MAKE) test >>> + cd Apache-SizeLimit && $(MAKE) test > >> Yeah, except the problem of failures and return codes, IMO. You want to >> run all 3 of these, no matter what. However, you want to return success >> if and only if they all worked and failure if *either* failed. > > This is where I dropped it at last. I never made it through. There was > some complexity that killed me. I forget what that was in 2k6 though.
How about this cute trick using make -k ? Quick testing seems to
indicate it ends up doing the right thing for me.
Index: Makefile.PL
===================================================================
--- Makefile.PL (revision 934250)
+++ Makefile.PL (working copy)
@@ -785,8 +785,17 @@
$(PASSENV) \
$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
t/TEST -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES)
- cd ModPerl-Registry && $(MAKE) test
+ $(MAKE) -k run_subtests
+run_subtests ::
+ $(MAKE) -C ModPerl-Registry test
+
+run_subtests ::
+ $(MAKE) -C Apache-Reload test
+
+run_subtests ::
+ $(MAKE) -C Apache-SizeLimit test
+
test :: pure_all run_tests test_clean
EOF
--
Philippe M. Chiasson GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/ m/gozer\@(apache|cpan|ectoplasm)\.org/
signature.asc
Description: OpenPGP digital signature
