On Tuesday, 14 February 2012 14:15:25 Steve Hay wrote: > I've committed the ModPerl::MM fix, renaming $b to $build
Thanks. It passes all tests here with linux, perl 5.12.3, worker and prefork. > And I definitely agree that any code commented "should not happen" ought to > assert when it does happen so that we (developers) can catch it in debug > builds. To that end, the MP_ASSERT macro that you've added to the threading > branch would be useful to have in trunk ASAP. I think we should simply rename the threading branch to trunk (or the SVN equivalent of "rename") after 2.0.6. Apart from ~2 changes everything that has been committed to trunk is also present in threading. And one of those blocked commits is the reverting of the cmdparams.pm. Fred, now that the OOM issue has been resolved is there anything left for 2.0.6 other than the Niko Tyni issue? It seems that I have missed a few messages in that regard. Are the following 2 patches all there is to it? http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=50;filename=0001-Fix-a- reference-counting-bug-uncovered-by-Perl-5.13..patch;att=2;bug=650675 http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=50;filename=0002-Fix-another- reference-counting-bug-uncovered-by-Perl.patch;att=3;bug=650675 Torsten Förtsch -- Need professional modperl support? Hire me! (http://foertsch.name) Like fantasy? http://kabatinte.net --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org