Hi, I am starting a new thread here because a) this is about RC2 not RC1 and b) the RC1 thread is already too long for me to cope with.
To summarize the current state as I see it. We have a RC2 at http://people.apache.org/~phred/mod_perl-2.0.6-rc2.tar.gz It got 2 +1 for linux (me) and osx (fred). On windows Steve reported another problem with recursive "make" invocations. He also sent a patch to the list but didn't commit it for some reason. If I understood the patch correctly the problem are the hard-wired "make" options (-k and -C). So, I committed a slightly different patch (more makeish I think). Steve, could you please confirm that revision 1245946 works for you? I have also just committed revision 1290839 to have our top-level Makefile.PL pass on MP_APXS and MP_AP_PREFIX as environment variables. At least this patch doesn't disturb anything here. But I doubt that it solves Steve's Apache- Reload problem. The A::R Makefile.PL reads: ... if ($ENV{MOD_PERL_2_BUILD}) { push @ARGV, "-apxs $ENV{MP_APXS}"; my $mp_gen = satisfy_mp_generation(2); } ... So the string "-apxs ..." is pushed to @ARGV as a single argument. I think that should rather read push @ARGV, "-apxs", $ENV{MP_APXS}; Steve, if you want to play with it remember to change the place where the additional parameter is removed from @ARGV later, as well. Around line 50 it reads: if ($ENV{MOD_PERL_2_BUILD}) { pop @ARGV; # that should now be 2 times pop or a splice } These lines of code are also present in A::SL and have their origin there. They appeared in revision 441414. Hopefully RC3 will then get 3 +1. I'd really like to get it over with before my vacation starting mid-next week but hope is weak. $ svn diff -c 1245946 Index: Makefile.PL =================================================================== --- Makefile.PL (revision 1245945) +++ Makefile.PL (revision 1245946) @@ -789,24 +789,23 @@ $(PASSENV) \ $(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \ t/TEST -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES) - $(MAKE) -k run_subtests run_subtests :: - $(MAKE) -C ModPerl-Registry test + cd ModPerl-Registry && $(MAKE) test run_subtests :: - $(MAKE) -C Apache-Reload test + cd Apache-Reload && $(MAKE) test EOF $preamble .= <<'EOF' unless $build->mpm_is_threaded(); run_subtests :: - $(MAKE) -C Apache-SizeLimit test + cd Apache-SizeLimit && $(MAKE) test EOF $preamble .= <<'EOF'; -test :: pure_all run_tests test_clean +test :: pure_all run_tests run_subtests EOF return $preamble; Another funny discovery I made in our top-level Makefile.PL. There is a function named win32_fetch_apxs which is called almost first thing if we run on WIN32. It looks for a win32_fetch_apxs executable. I found such a script in build/. It tries to fetch the archive http://perl.apache.org/dist/win32- bin/apxs_win32.tar.gz via LWP. The newest files in this directory from 2007-04-18 03:32. Do we really need this? Torsten Förtsch -- Need professional modperl support? Hire me! (http://foertsch.name) Like fantasy? http://kabatinte.net --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org For additional commands, e-mail: dev-h...@perl.apache.org
