Apache-Test 1.13 introduced the APACHE_TEST_EXTRA_ARGS make variable
"to allow passing extra arguments from the command line", but the mod_perl
Makefile itself was never modified use that. The attached proposed patch
tries to rectify this.

We're using APACHE_TEST_EXTRA_ARGS in Debian to run the test suite in
package builds with a controlled httpd config instead of relying on the
system one (which may not have all the necessary Apache modules enabled,
for instance.)
-- 
Niko Tyni   nt...@debian.org
>From 33962b95d064401f36c82e5f03bcaa898fe696f7 Mon Sep 17 00:00:00 2001
From: Niko Tyni <nt...@debian.org>
Date: Tue, 18 Jun 2013 21:48:37 +0300
Subject: [PATCH] Honour APACHE_TEST_EXTRA_ARGS

Apache-Test 1.13 introduced the APACHE_TEST_EXTRA_ARGS make variable
"to allow passing extra arguments from the command line", but the mod_perl
Makefile itself was never modified use that.
---
 Makefile.PL |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.PL b/Makefile.PL
index 132d194..ad55629 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -788,12 +788,12 @@ TEST_FILES =
 
 test_clean :
 	$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
-	t/TEST -clean
+	t/TEST $(APACHE_TEST_EXTRA_ARGS) -clean
 
 run_tests : test_clean
 	$(PASSENV) \
 	$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
-	t/TEST -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES)
+	t/TEST $(APACHE_TEST_EXTRA_ARGS) -bugreport -verbose=$(TEST_VERBOSE) $(TEST_FILES)
 
 run_subtests ::
 	cd ModPerl-Registry && $(MAKE) test
-- 
1.7.10.4


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org

Reply via email to