On 04/28/2014 03:03 PM, Jan Kaluža wrote:
On 04/28/2014 02:57 PM, Torsten Förtsch wrote:
Hi Jan,

On 28/04/14 13:22, Jan Kaluža wrote:
On 04/23/2014 03:04 PM, Torsten Förtsch wrote:
On 23/04/14 13:21, Jan Kaluža wrote:
Thanks for that summary Torsten. As I understand it right now, we
should
build mod_perl with httpd-2.4 with "-Duseithreads
-Dusemultiplicity" and
allow building with other combination if user explicitly wants it (set
some command line parameter during build), right?

We should by default require a Perl built with "-Duseithreads
-Dusemultiplicity". If the user explicitly wants it, we should also
accept a Perl built with "-Uuseithreads -Uusemultiplicity".

All other combinations should be refused.

Can you please check attached patch? If I understand you correctly, it
should do what you propose.

Can you please check what the difference between NONTHREADED_OK and
NO_THREADS is. They seem to serve the same purpose.

I've checked that before sending the patch and it looks like this option
is not used by anything:

Although.... I'm not sure right now...

http://svn.apache.org/viewvc?view=revision&revision=r1151822

Btw, you are the author of that :-P.

$ grep "NONTHREADED_OK" -R .
./lib/ModPerl/BuildOptions.pm:NONTHREADED_OK 0    Using a non-threaded
perl is okay with httpd >=2.3
./blib/lib/ModPerl/BuildOptions.pm:NONTHREADED_OK 0    Using a
non-threaded perl is okay with httpd >=2.3

I think we can remove that option, or if you like this name better, I
can use it in my patch.

Torsten


Jan Kaluza


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org


Jan Kaluza


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org

Reply via email to