[ 
https://issues.apache.org/jira/browse/PHOENIX-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kyle Buzsaki updated PHOENIX-1002:
----------------------------------

    Attachment: PHOENIX-1002_5.patch

Looks like the division expression just lets the underlying ArithmeticException 
bubble up. I've removed my check for a 0 divisor to be consistent with that and 
revised the integration test accordingly. I've also switched the 
ptr.getLength() == 0 checks to return true as you advised.

For the + and - operator precedence testing, there's already a test that does 
just that in my operator precedence patch at PHOENIX-1075 . I've been keeping 
the two separate for now and only uploading the patches for this issue relative 
to that patch rather than relative to master. The operator precedence patch 
will have to be merged in first, or I can include the relevant precedence 
fixing commits in this patch file instead.

> Add support for % operator
> --------------------------
>
>                 Key: PHOENIX-1002
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1002
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Thomas D'Silva
>         Attachments: PHOENIX-1002.patch, PHOENIX-1002_2.patch, 
> PHOENIX-1002_3.patch, PHOENIX-1002_4.patch, PHOENIX-1002_5.patch
>
>
> Supporting the % operator would allow using sequences to generate IDs that 
> are less than a maximum number. 
> CREATE SEQUENCE foo.bar
> SELECT ((NEXT VALUE FOR foo.bar)%1000)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to