Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/3#discussion_r14859843
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java ---
    @@ -169,7 +170,7 @@ private boolean 
hasImmutableIndexWithKeyValueColumns(TableRef tableRef) {
             }
             for (PTable index : tableRef.getTable().getIndexes()) {
                 for (PColumn column : index.getPKColumns()) {
    -                if (!IndexUtil.isDataPKColumn(column)) {
    +                if (!IndexUtil.isDataPKColumn(column) && 
(index.getIndexType() != IndexType.LOCAL || 
!column.getName().toString().equals(MetaDataUtil.VIEW_INDEX_ID_COLUMN_NAME))) {
    --- End diff --
    
    Thinking about this more, it should probably just be disallowed to create a 
local index on a table with immutable rows. I'm not sure if there's a need and 
I suspect we haven't tested this combination. We can always add it 
down-the-road.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to