[
https://issues.apache.org/jira/browse/PHOENIX-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067343#comment-14067343
]
Thomas D'Silva commented on PHOENIX-1016:
-----------------------------------------
[~jamestaylor] , that was the problem. BaseTest.initAndRegisterDriver was
creating a connection when calling driver.connect, but was not closing the
connection. When I closed the connection and ran the test, it calls
returnAllSequences.
I will remove my changes to explicitly call returnAllSequences and upload a
final (hopefully) version of the patch.
{code}
/**
* Create a {@link PhoenixTestDriver} and register it.
* @return an initialized and registered {@link PhoenixTestDriver}
*/
protected static PhoenixTestDriver initAndRegisterDriver(String url,
ReadOnlyProps props) throws Exception {
PhoenixTestDriver driver = new PhoenixTestDriver(props);
DriverManager.registerDriver(driver);
Assert.assertTrue(DriverManager.getDriver(url) == driver);
Connection conn = driver.connect(url, TestUtil.TEST_PROPERTIES);
conn.close();
return driver;
}
{code}
> Support MINVALUE, MAXVALUE, and CYCLE options in CREATE SEQUENCE
> ----------------------------------------------------------------
>
> Key: PHOENIX-1016
> URL: https://issues.apache.org/jira/browse/PHOENIX-1016
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Attachments: AddSeqColumns.txt, PHOENIX-1016-3.1.v3.patch,
> PHOENIX-1016-3.1.v4.patch, PHOENIX-1016-4.1.v3.patch,
> PHOENIX-1016-4.1.v4.patch, PHOENIX-1016.3.0.patch, PHOENIX-1016.patch,
> PHOENIX-1016.v2.3.0.patch, PHOENIX-1016.v2.patch, diff.txt
>
>
> We currently don't support MINVALUE, MAXVALUE, and CYCLE options in CREATE
> SEQUENCE, but we should. See
> http://msdn.microsoft.com/en-us/library/ff878091.aspx for the syntax.
> I believe MINVALUE applies if the INCREMENT is negative while MAXVALUE
> applies otherwise. If the value of a sequence goes beyond MINVALUE/MAXVALUE,
> then:
> - if CYCLE is true, then the sequence value should start again at the START
> WITH value (or the MINVALUE if specified too? Not sure about this).
> - if CYCLE is false, then an exception should be thrown.
> To implement this:
> - make the grammar changes in PhoenixSQL.g
> - add member variables for MINVALUE, MAXVALUE, and CYCLE to
> CreateSequenceStatement
> - add the appropriate error checking and handle bind variables for these new
> options in CreateSequenceCompiler
> - modify the MetaDataClient.createSequence() call by passing along these new
> parameters.
> - same for ConnectionQueryServices.createSequence() call
> - same for Sequence.createSequence().
> - pass along these parameters as new KeyValues in the Append that constitutes
> the RPC call
> - act on these in the SequenceRegionObserver coprocessor as indicated above.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
