[ 
https://issues.apache.org/jira/browse/PHOENIX-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069730#comment-14069730
 ] 

James Taylor commented on PHOENIX-1104:
---------------------------------------

Looks good. Would you mind adding a comment to BaseQueryServicesImpl.close() to 
explain why we don't shutdown the executor?
// Do not shutdown the executor as it prevents the Driver from being able
// to attempt to open a connection in the future.

> Do not shutdown threadpool when initialization fails
> ----------------------------------------------------
>
>                 Key: PHOENIX-1104
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1104
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0, 3.1, 4.1
>            Reporter: Mujtaba Chohan
>            Priority: Minor
>             Fix For: 5.0.0, 3.1, 4.1
>
>         Attachments: P-1104.patch
>
>
> If Phoenix first connects when HBase master is initializing then Phoenix 
> throws Incompatible jar exception on subsequent connections from same JVM.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to