[ 
https://issues.apache.org/jira/browse/PHOENIX-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070530#comment-14070530
 ] 

James Taylor commented on PHOENIX-763:
--------------------------------------

Thanks so much for the patch,[~maghamravikiran]. Couple of high level comments:
- Can you add a detailed comment to the javadoc for the 
org/apache/phoenix/sqoop/PhoenixSqlManager.java class that explains the high 
level flow for import and export? Also, any limitations that may exist. Or if 
you think this is more appropriate in a different class or classes, that's fine 
too.
- Can you add a test with a composite/multi-part primary key, as that's an 
important use case for Phoenix. Is that supported?
- Can you file a sub-task to this one to document the Sqoop integration on our 
website?
- As far as hadoop1/hadoop2 support for the 4.0 branch, it's ok if you just get 
something working on hadoop2 as we're planning on dropping hadoop1 support for 
4.x soon. If you need help, [~jesse_yates] may be able to see something awry if 
you point him to the right place.

[~gabriel.reid] - are you familiar with Scoop? Would you have any spare cycles 
to review this?


> Support for Sqoop
> -----------------
>
>                 Key: PHOENIX-763
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-763
>             Project: Phoenix
>          Issue Type: Task
>    Affects Versions: 3.0.0
>            Reporter: James Taylor
>            Assignee: mravi
>              Labels: patch
>         Attachments: PHOENIX-763-300B.patch
>
>
> Not sure anything required from our end, but you should be able to use Sqoop 
> to create and populate Phoenix tables.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to