[
https://issues.apache.org/jira/browse/PHOENIX-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073767#comment-14073767
]
James Taylor commented on PHOENIX-1083:
---------------------------------------
Thanks for the additional tests, [~samarthjain] and [~kbuzsaki]. I've committed
them to all branches. I made a slight tweak to only salt up to 4 buckets. Over
this, the mini cluster can get overloaded based on our default settings. Plus a
non salting plus single salting case is good enough coverage (the number of
salt buckets doesn't have an impact on the flow).
Would you mind filing a follow-up JIRA, [~kbuzsaki], on adding tests to
WhereOptimizerTest that validate the correct optimizer path is taken for the
trailing/leading/overlap RVC cases? Also, [~samarthjain] - can you file a
follow up JIRA to enhance your query optimizer tests to assert that the skip
scan List<List<KeyRange>> is as expected?
> IN list of RVC combined with AND doesn't return expected rows
> -------------------------------------------------------------
>
> Key: PHOENIX-1083
> URL: https://issues.apache.org/jira/browse/PHOENIX-1083
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0, 4.0.0, 5.0.0
> Reporter: Samarth Jain
> Assignee: James Taylor
> Fix For: 5.0.0, 3.1, 4.1
>
> Attachments: InListIT.java, InListIT.java, PHOENIX-1083_3.0.patch,
> PHOENIX-1083_3.0_additionaltests.patch,
> PHOENIX-1083_AdditionalInListIT.patch, rvcBug-v1.patch, rvcBug-wip2.patch,
> rvcBug-wip3.patch
>
>
> {code}
> CREATE TABLE in_test ( user VARCHAR, tenant_id VARCHAR(5) NOT
> NULL,tenant_type_id VARCHAR(3) NOT NULL, id INTEGER NOT NULL CONSTRAINT pk
> PRIMARY KEY (tenant_id, tenant_type_id, id))
> upsert into in_test (tenant_id, tenant_type_id, id, user) values ('a', 'a',
> 1, 'BonA')
> upsert into in_test (tenant_id, tenant_type_id, id, user) values ('a', 'a',
> 2, 'BonB')
> select id from in_test WHERE tenant_id = 'a' and tenant_type_id = 'a' and
> ((id, user) IN ((1, 'BonA'),(1, 'BonA')))
> Rows returned - none. Should have returned one row.
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
