[ 
https://issues.apache.org/jira/browse/PHOENIX-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075804#comment-14075804
 ] 

James Taylor commented on PHOENIX-1112:
---------------------------------------

A little bit more feedback:

In this function in MetaDataClient, please use the buildIndex() as your entry 
point instead of using PostIndexDDLCompiler directly. If you need to add an 
additional argument for the time range, that's fine. The reason is that this is 
the entry point for rebuilding the index and local indexing specific updates 
are here.
+    public void buildPartialIndexFromTimeStamp(PTable index, TableRef 
dataTableRef,
+        long lowerBoundTimeStamp) throws SQLException {

Also, good catch on upping the minor version in MetaDataProtocol, but I'm going 
to make that change independent of your check-in.


> Atomically rebuild index partially when index update fails  
> ------------------------------------------------------------
>
>                 Key: PHOENIX-1112
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1112
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>         Attachments: Phoenix-1112.patch
>
>
> This is a short-term work around & safe approach. Currently we disable an 
> index when index update failed(still possible bring down the whole cluster). 
> After an index is disable, human needs to be involved to rebuild entire index 
> which maybe not ideal.
> The patch adds the support to automatically rebuild an disable index 
> partially from where it failed. In addition, it removes RS abort during WAL 
> recovery to prevent chain failures because we don't have to.
> To disable automatically rebuilding failed index, add the following 
> configuration into hbase-site.xml:
> {noformat}
> <property>
>    <name>phoenix.index.failure.handling.rebuild</name>
>    <value>false</value>
> </property>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to