Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/6#discussion_r15509748
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexFailureIT.java
---
@@ -159,5 +153,21 @@ public void testWriteFailureDisablesIndex() throws
Exception {
assertEquals(INDEX_TABLE_NAME, rs.getString(3));
assertEquals(PIndexState.DISABLE.toString(),
rs.getString("INDEX_STATE"));
assertFalse(rs.next());
+
--- End diff --
Are there more tests? How about testing these scenarios:
* updates coming into a table with a disable index (to make sure no updates
are lost)
* partially updating the index table
* partially updating a local index table
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
