[ 
https://issues.apache.org/jira/browse/PHOENIX-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084366#comment-14084366
 ] 

James Taylor commented on PHOENIX-1137:
---------------------------------------

+1 on the patch. We have a fair number unit tests for the plan generation and 
optimization (can always use more, of course), but this is a bit of an edge 
case, as it filters particular regions. The best one to add a test case for 
this would be SkipRangeParallelIteratorRegionSplitterIT. For unit tests that 
test plan generation and optimization, ake a look at WhereOptimizerTest, 
WhereCompilerTest, and QueryPlanIT.

How about we file a follow up JIRA to add a unit test for this and get this 
patch into the upcoming release?

> SkipScanFilter.intersect not called for aggregate queries
> ---------------------------------------------------------
>
>                 Key: PHOENIX-1137
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1137
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>             Fix For: 3.1, 4.1
>
>         Attachments: PHOENIX-1137.txt
>
>
> See ScanUtil.intersectScanRange. If the filter is a list and the 
> SkipScanFilter is in 2nd position we won't call intersect.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to