[ 
https://issues.apache.org/jira/browse/PHOENIX-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088671#comment-14088671
 ] 

James Taylor commented on PHOENIX-1147:
---------------------------------------

Instead of adding *another* empty key value, do a put of the one that's already 
there:
{code}
+                    if(dataTableKey != null) {
+                        // insert an empty KV to trigger time stamp update on 
data table row
+                        Put p = new Put(dataTableKey);
+                        p.add(TABLE_FAMILY_BYTES, 
QueryConstants.EMPTY_COLUMN_BYTES, timeStamp, ByteUtil.EMPTY_BYTE_ARRAY);
+                        tableMetadata.add(p);
+                    }
{code}

> Add test cases to cover more index update failure scenarios
> -----------------------------------------------------------
>
>                 Key: PHOENIX-1147
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1147
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.0.0, 5.0.0
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>         Attachments: Phoenix-1147-v1.patch, Phoenix-1147-v2.patch
>
>
> Add one test to cover RegionServer being killed while index is begin updated
> Add steps to make sure UPSERT & SELECT should still work after index is 
> disabled.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to