[ 
https://issues.apache.org/jira/browse/PHOENIX-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089926#comment-14089926
 ] 

Jeffrey Zhong commented on PHOENIX-1147:
----------------------------------------

{quote}
 Code similar to the code you added in MetaDataClient already exists in 
PMetaDataImpl.removeTable()
{quote}
You're right. That code in PMetaDataImpl.removeTable() is removed in v3 patch 
because we had a situation that index table isn't in cache so the code there 
won't be triggered and there won't be parentTable info as there is no cache for 
index table. 
In addition, that code had a small issue that we only add the new PTable into 
current connection's metadata not the QuerySerivce. That's why I made the 
change in a upper level. 

For the equalsIgnoreCase, I can change it during my check in. Thanks for the 
good comments!

> Ensure data table is sent to client if index table changes states
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-1147
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1147
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.0.0, 5.0.0
>            Reporter: Jeffrey Zhong
>            Assignee: Jeffrey Zhong
>         Attachments: Phoenix-1147-v1.patch, Phoenix-1147-v2.patch, 
> Phoenix-1147-v3.patch
>
>
> Add one test to cover RegionServer being killed while index is begin updated
> Add steps to make sure UPSERT & SELECT should still work after index is 
> disabled.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to