[
https://issues.apache.org/jira/browse/PHOENIX-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097727#comment-14097727
]
Jeffrey Zhong commented on PHOENIX-1171:
----------------------------------------
Looks good to me(+1) with one minor comment.
{code}
+ if (parentTableName != null && Bytes.compareTo(parentTableName,
table.getParentTableName().getBytes()) != 0) {
+ return new MetaDataMutationResult(MutationCode.TABLE_NOT_FOUND,
EnvironmentEdgeManager.currentTimeMillis(), null);
+ }
{code}
I think we better check full table name including schemaName as well in the
above check.
> Dropping the index is not verifying the associated table
> --------------------------------------------------------
>
> Key: PHOENIX-1171
> URL: https://issues.apache.org/jira/browse/PHOENIX-1171
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.0.0
> Environment: Linux HDP-2.1
> Reporter: yeshwanth
> Assignee: James Taylor
> Labels: newbie, patch
> Attachments: PHOENIX-1171.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> i had two tables,
> i created index on one table and dropped index by specifying other table,
> index was dropped succesfully, later when i tried indexing on the same table,
> it had thrown me error saying the index table name already exists,
> looks like, the reference was not updated in phoenix table,
> 0: jdbc:phoenix:localhost:/hbase-unsecure> create table t1( id integer not
> null primary key ,name char(5));
> No rows affected (17.666 seconds)
> 0: jdbc:phoenix:localhost:/hbase-unsecure> create table t2( id integer not
> null primary key ,name char(5));
> No rows affected (1.296 seconds)
> 0: jdbc:phoenix:localhost:/hbase-unsecure> CREATE INDEX i1 ON t1 (id);
> No rows affected (3.164 seconds)
> 0: jdbc:phoenix:localhost:/hbase-unsecure> DROP INDEX i1 on t2;
> No rows affected (2.023 seconds)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
