[ 
https://issues.apache.org/jira/browse/PHOENIX-1196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121756#comment-14121756
 ] 

Jesse Yates commented on PHOENIX-1196:
--------------------------------------

Offline discussion w/ Eli came to the conclusion that we could just make the 
property:
{code}
phoenix.trace.custom.annotation.<annotation key>=<annotation value>
{code}
That would be compatible with the existing tracing properties, which start with 
"phoenix.trace" (in QueryServices.java) and just assumes that the value is a 
String. We can add typing later by checking the next word after the common 
prefix. For example the value from,
{code}
phoenix.trace.custom.annotation.my-custom-key
{code}
would still be treated as a String/varchar and the value from
{code}
phoenix.trace.custom.annotation.smallint.my-other-custom-key
{code}
would be a smallint, etc. I'm merely making this examples to show that we have 
the flexibility to add typing later - not that is should be tackled as part of 
this JIRA.




> Add ability to add custom tracing annotations for connections
> -------------------------------------------------------------
>
>                 Key: PHOENIX-1196
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1196
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Eli Levine
>            Assignee: Eli Levine
>             Fix For: 5.0.0, 4.1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to